feat: Automatically use the right validator based on runtime #1065
+33
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates package.json export conditions and to pick the right validator based on runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates package.json internal imports conditions and to pick the right validator based on runtime.
Motivation and Context
Instead of needing to explicitly import
@modelcontextprotocol/sdk/validation/cfworkerand use it, we can simply pick it directly for the workerd condition (which wrangler / the cloudflare vite plugin will do).How Has This Been Tested?
Did some cursory testing, I'll test it some more over the weekend.
Breaking Changes
No breaking changes!
Types of changes
Checklist
Additional context